Skip to content

fix(batch): remove default optimal for arm based instance types and add error checks#31510

Merged
mergify[bot] merged 15 commits intoaws:mainfrom
1kaileychen:remove_optimal_for_arm_based_instance_types
Oct 1, 2024
Merged

fix(batch): remove default optimal for arm based instance types and add error checks#31510
mergify[bot] merged 15 commits intoaws:mainfrom
1kaileychen:remove_optimal_for_arm_based_instance_types

Conversation

@1kaileychen
Copy link
Copy Markdown
Contributor

@1kaileychen 1kaileychen commented Sep 20, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31148

Reason for this change

When adding an arm-based instance, optimal instance is set by default which consists of an x86-based instance. This causes errors since arm and x86 instances can't be mixed together.

Description of changes

  • useOptimalInstanceClasses is set to false for all arm-based instances
  • Throws error when trying to mix x86 and arm instances
    • Case 1: Instantiating the class
    • Case 2: addInstanceClass and addInstanceType functions
  • Warning useOptimalInstanceClasses is being set to false for arm-based instances

Description of how you validated changes

  • Unit test where optimal doesn't get added for arm-based instances
  • Unit tests to display errors when instantiating the class
  • Unit tests to display errors when addInstanceClass and addInstanceType is adding mixed instances
  • Unit tests to display warning for arm based instances

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 20, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 20, 2024 16:41
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 20, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@1kaileychen 1kaileychen removed the request for review from a team September 20, 2024 17:07
@1kaileychen 1kaileychen changed the title Remove optimal for arm based instance types fix(aws-batch) : Remove default optimal for arm based instance types and add error checks Sep 20, 2024
@1kaileychen 1kaileychen changed the title fix(aws-batch) : Remove default optimal for arm based instance types and add error checks fix(aws-batch): remove default optimal for arm based instance types and add error checks Sep 20, 2024
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Sep 20, 2024
@1kaileychen 1kaileychen changed the title fix(aws-batch): remove default optimal for arm based instance types and add error checks fix(batch): remove default optimal for arm based instance types and add error checks Sep 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 23, 2024 20:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@1kaileychen 1kaileychen marked this pull request as ready for review September 23, 2024 21:16
@shikha372 shikha372 self-assigned this Sep 26, 2024
shikha372
shikha372 reviewed Sep 26, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 26, 2024
shikha372
shikha372 reviewed Sep 26, 2024
View reviewed changes
@shikha372 shikha372 added the pr/do-not-merge This PR should not be merged at this time. label Oct 1, 2024
@shikha372
Copy link
Copy Markdown
Contributor

shikha372 commented Oct 1, 2024

Marking it as do not merge for confirming test changes

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 1, 2024
@shikha372 shikha372 removed the pr/do-not-merge This PR should not be merged at this time. label Oct 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 1, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 43e5c82
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7e80cc9 into aws:main Oct 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@shikha372 shikha372 shikha372 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shikha372 shikha372

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-cdk/aws-batch: Skip use of optimal instance type with graviton instances

3 participants

@1kaileychen @shikha372 @aws-cdk-automation