Skip to content

chore(ec2): add GuardDuty Interface VPC Endpoint#31477

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
badmintoncryer:guradDutyPrivateLink
Sep 19, 2024
Merged

chore(ec2): add GuardDuty Interface VPC Endpoint#31477
mergify[bot] merged 2 commits intoaws:mainfrom
badmintoncryer:guradDutyPrivateLink

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Sep 18, 2024 •
edited
Loading

Issue # (if applicable)

None

Reason for this change

GuardDuty supports private link access but AWS CDK does not support creating an interface VPC endpoint for GuardDuty.

Description of changes

Add Interface VPC Endpoint for AWS GuardDuty.

Description of how you validated changes

I executed the AWS CLI command as shown below.

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep guardduty
    "com.amazonaws.us-east-1.guardduty", // added
    "com.amazonaws.us-east-1.guardduty-data", // added
    "com.amazonaws.us-east-1.guardduty-data-fips",
    "com.amazonaws.us-east-1.guardduty-fips",

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 18, 2024 09:54
@github-actions github-actions bot added the p2 label Sep 18, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 18, 2024
GavinZZ
GavinZZ previously approved these changes Sep 18, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Sep 19, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review September 19, 2024 01:32

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 19, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cb01ee6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Sep 19, 2024

@GavinZZ Could you please approve this PR again?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 70beb6a into aws:main Sep 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 19, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2024
@badmintoncryer badmintoncryer deleted the guradDutyPrivateLink branch September 19, 2024 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badmintoncryer @aws-cdk-automation @GavinZZ