Skip to content

chore(vpcv2): fix doc issue due to IRoute#31464

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
shikha372:vpcv2_doc_fix
Sep 18, 2024
Merged

chore(vpcv2): fix doc issue due to IRoute#31464
mergify[bot] merged 3 commits intoaws:mainfrom
shikha372:vpcv2_doc_fix

Conversation

@shikha372
Copy link
Copy Markdown
Contributor

@shikha372 shikha372 commented Sep 16, 2024

Issue # (if applicable)

Closes #NA.

Reason for this change

Fixes the doc job build failure for python docs failing with the error in main pipeline

TypeError: Cannot create a consistent method resolution
order (MRO) for bases IConstruct, IResource, Protocol

Issue seemed to have been occured due to IRoute interface extending both IConstruct and IResource,
we don't need it as IResource already extends IConstruct and IConstruct extends IDependable.

Description of changes

Renamed IRoute to IRouteV2(as previous release) , we already have an interface in the main lib with name IRoute for apigateway

Description of how you validated changes

Deployed in test-pipeline for verification using

git fetch origin pull/31464/head
git push -f origin FETCH_HEAD:test-main-pipeline

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 16, 2024
@github-actions github-actions bot added the p2 label Sep 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 16, 2024 21:56
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title (chore): fix doc issue chore(vpcv2): fix doc issue Sep 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself September 16, 2024 22:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 changed the title chore(vpcv2): fix doc issue chore(vpcv2): fix doc issue due to IRoute Sep 16, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 775bc9f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shikha372 shikha372 marked this pull request as ready for review September 18, 2024 14:57
@shikha372
Copy link
Copy Markdown
Contributor Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify mergify bot merged commit 144cc8b into aws:main Sep 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants