chore(ec2): invalid Interface VPC Endpoints by badmintoncryer · Pull Request #31441 · aws/aws-cdk

badmintoncryer · 2024-09-13T11:47:14Z

Issue # (if applicable)

None

Reason for this change

The wrong URLs were set for several Interface Endpoints, so I corrected them.

For example, when retrieving the freetier endpoint via CLI, it shows as aws.api.{region}.freetier, but in CDK, it was set to com.amazonaws.{region}.freetire.

I believe this correction might be a breaking change, but since the previous URLs likely wouldn't have allowed access anyway, I'm unsure how to proceed. Which of the following approaches would be best?

Directly fix the incorrect URLs (the current implementation)
Implement a feature flag
Deprecate the existing method and implement a new one

Description of changes

Update URL from com.amazonaws.{region}.{service} to aws.api.{region}.{service}

freetier
bcm-data-exports

Description of how you validated changes

I've executed described-vpc-endpoint-services CLI.

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep aws.api
    "aws.api.us-east-1.bcm-data-exports",
    "aws.api.us-east-1.freetier",
    "aws.api.us-east-1.kendra-ranking",
    "aws.api.us-east-1.qbusiness",

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

badmintoncryer · 2024-09-13T11:51:31Z

exemption request
I don't think this PR requires updates to the README or test files.

GavinZZ

Thank you for the fix!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2024-09-18T05:33:11Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-09-18T08:04:54Z

@mergify update

mergify · 2024-09-18T08:05:04Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

badmintoncryer · 2024-09-18T09:48:30Z

@mergify update

mergify · 2024-09-18T09:48:41Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

badmintoncryer · 2024-09-18T11:00:00Z

@mergify update

mergify · 2024-09-18T11:00:05Z

update

✅ Branch has been successfully updated

badmintoncryer · 2024-09-18T12:40:15Z

@Mergifyio update

mergify · 2024-09-18T12:40:24Z

update

☑️ Nothing to do

Details

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

badmintoncryer · 2024-09-18T12:41:16Z

@Mergifyio refresh

mergify · 2024-09-18T12:41:24Z

refresh

✅ Pull request refreshed

Pull request has been modified.

mergify · 2024-09-18T20:20:23Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-09-18T21:43:44Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 5bc865c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-09-18T21:44:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-09-18T21:44:34Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

update interface endpoint

9dfaf43

aws-cdk-automation requested a review from a team September 13, 2024 11:47

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 13, 2024

aws-cdk-automation previously requested changes Sep 13, 2024

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 13, 2024

Merge branch 'main' into updateInterfaceEndpoint

16d9a7c

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 13, 2024

go-to-k approved these changes Sep 14, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 14, 2024

github-actions bot mentioned this pull request Sep 16, 2024

Weekly PR metrics report #31456

Closed

GavinZZ changed the title ~~fix(ec2): invalid Interface VPC Endpoints~~ chore(ec2): invalid Interface VPC Endpoints Sep 18, 2024

GavinZZ previously approved these changes Sep 18, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 18, 2024

Merge branch 'main' into updateInterfaceEndpoint

2009d4d

Merge branch 'main' into updateInterfaceEndpoint

10d1823

GavinZZ approved these changes Sep 18, 2024

View reviewed changes

Merge branch 'main' into updateInterfaceEndpoint

5bc865c

mergify bot merged commit 1581190 into aws:main Sep 18, 2024

github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024

badmintoncryer deleted the updateInterfaceEndpoint branch September 18, 2024 23:37

Conversation

badmintoncryer commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented Sep 13, 2024

Uh oh!

GavinZZ left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

badmintoncryer commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

❌ Mergify doesn't have permission to update

Uh oh!

badmintoncryer commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

❌ Mergify doesn't have permission to update

Uh oh!

badmintoncryer commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

✅ Branch has been successfully updated

Uh oh!

badmintoncryer commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

☑️ Nothing to do

Uh oh!

badmintoncryer commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

✅ Pull request refreshed

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

aws-cdk-automation commented Sep 18, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

github-actions bot commented Sep 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

badmintoncryer commented Sep 13, 2024 •

edited

Loading