fix(cognito): deprecate privateKey and add privateKeyValue as typed SecureValue#31409
Conversation
packages/aws-cdk-lib/aws-cognito/test/user-pool-idps/apple.test.ts
Outdated
Show resolved
Hide resolved
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
Have you tested this by deploying to CFN? |
|
Unfortunately I don't have a valid private_key for that. And there's no existing integ test for that as well so I am offering unit tests only.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31378
Reason for this change
privateKeywas typedstringwhich should beSecureValuejust as clientSecretValue in Google IdP. This PR deprecatesprivateKeyand addsprivateKeyValuewith correct type.apple.tswas named by mistake and it won't be unit tested. This PR renames it toapple.test.tsso it would be covered. Figured an existing test was failed, just fixed that failed one as well.Description of changes
privateKeyValueproperty of type SecretValue to UserPoolIdentityProviderApplePropsprivateKeystring propertyprivateKeyorprivateKeyValueis providedprivateKeyValuewhen availableUsers must now provide either
privateKeyorprivateKeyValue,but not both. This change enhances security by allowing the use of SecretValue
for the Apple IDP private key.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license