Skip to content

feat(opensearch): support OpenSearch version 2.15#31398

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:opensearch-domain-2-15
Sep 17, 2024
Merged

feat(opensearch): support OpenSearch version 2.15#31398
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:opensearch-domain-2-15

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Sep 10, 2024

Issue # (if applicable)

N/A

Reason for this change

Amazon OpenSearch Service supports OpenSearch version 2.15.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-opensearch-service-version-2-15/

% aws opensearch list-versions --region us-east-1

{
    "Versions": [
        "OpenSearch_2.15",
        "OpenSearch_2.13",
        "OpenSearch_2.11",
// omit

Description of changes

Add ver 2.15 enum

Description of how you validated changes

Add unit test and integ test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 10, 2024 23:40
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 10, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

},
};
const versions = [
opensearch.EngineVersion.OPENSEARCH_2_13,
Copy link
Copy Markdown
Contributor Author

@mazyu36 mazyu36 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified to be able to test multiple versions.
It tests the existing version 2.13 and the newly added version 2.15.

I considered adding all versions as well, but I thought that might be overkill, so I haven't.

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Sep 10, 2024

Exemption Request: As this only involves adding an enum for versions, I think that modifying the README was unnecessary.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 10, 2024
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Sep 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 17, 2024 14:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 17, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b34c963
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 33eea3f into aws:main Sep 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@mazyu36 mazyu36 deleted the opensearch-domain-2-15 branch September 17, 2024 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants