Skip to content

chore(diff): fomatter unit test fails locally#31396

Merged
mergify[bot] merged 2 commits intomainfrom
comcalvi/formatter-test-fix
Sep 10, 2024
Merged

chore(diff): fomatter unit test fails locally#31396
mergify[bot] merged 2 commits intomainfrom
comcalvi/formatter-test-fix

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi commented Sep 10, 2024

Issue # (if applicable)

N/A

Reason for this change

format value can handle partial json strings fails the repo build on my machine. This doesn't happen at the package level, for some reason.

Description of changes

Made it pass the repo build.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 10, 2024 22:48
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 10, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 49e0d8b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1794dc4 into main Sep 10, 2024
@mergify mergify bot deleted the comcalvi/formatter-test-fix branch September 10, 2024 23:21
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants