fix(ecs): ecs exec cannot be enabled for ECS Anywhere (ecs.ExternalService)#31374
fix(ecs): ecs exec cannot be enabled for ECS Anywhere (ecs.ExternalService)#31374mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: unable to execute integ test. To complete the deployment, an external instance such as a VM is required, but I think this is very difficult in integ test. I tried running the integration test, but since the external instance did not exist, the deployment could not be completed. 
During the deployment, I confirmed that the % aws ecs describe-services --cluster aws-ecs-integ-external-exec-command-ExternalCluster14BF29C2-1WgNGhaSCe6j --service aws-ecs-integ-external-exec-command-ExternalService9AC5437C-yEbQ87UFPByK --region us-east-1
{
"services": [
{
"serviceArn": "arn:aws:ecs:us-east-1:...
// omit
"enableExecuteCommand": true
// omit
} |
|
@go-to-k |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31181.
Reason for this change
In the
ecs.ExternalServiceclass (ECS Anywhere), theenableExecuteCommandproperty cannot be set to true, so it is not possible to enable ECS exec.However, the documentation states that ECS Anywhere supports ECS Exec.
Description of changes
Remove unnecessary if statement.
Description of how you validated changes
Fix an unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license