Skip to content

fix(core): improve context providers error message for env-agnostic stacks#3137

Merged
eladb merged 3 commits intomasterfrom
benisrae/fix-env-agnostic-message
Jul 1, 2019
Merged

fix(core): improve context providers error message for env-agnostic stacks#3137
eladb merged 3 commits intomasterfrom
benisrae/fix-env-agnostic-message

Conversation

@eladb
Copy link
Copy Markdown
Contributor

@eladb eladb commented Jun 30, 2019 •
edited
Loading

Following up on #2922: improve the error message emitted when trying to read context from an environment-agnostic stack by calling out CDK_DEFAULT_ACCOUNT and CDK_DEFAULT_REGION as a way to inherit environment information from the CLI.

Fixes #3078
Fixes #3120
Fixes #3130

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix(core): improve context providers error message for env-agnostic s…
22eec95 
…tacks

Following up on #2922: improve the error message emitted when trying to read context from an environment-agnostic stack by calling out CDK_DEFAULT_ACCOUNT and CDK_DEFAULT_REGION as a way to inherit environment information from the CLI.

Fixes #3078 
Fixes #3120 
Fixes #3130
@eladb eladb requested a review from a team as a code owner June 30, 2019 18:17
@ghost ghost requested a review from rix0rrr June 30, 2019 18:17
@eladb eladb changed the title fix(core): improve context providers error message for env-agnostic s… fix(core): improve context providers error message for env-agnostic stacks Jun 30, 2019
@eladb eladb merged commit 5b80146 into master Jul 1, 2019
@eladb eladb deleted the benisrae/fix-env-agnostic-message branch July 1, 2019 08:31
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

2 more reviewers

@garnaat garnaat garnaat approved these changes

@shivlaks shivlaks shivlaks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

4 participants

@eladb @garnaat @shivlaks @NGL321