Skip to content

fix(rds): proxy target group does not depend on database instances when using writer property for database cluster#31354

Merged
mergify[bot] merged 13 commits intoaws:mainfrom
go-to-k:rds-data-proxy-depends
Sep 9, 2024
Merged

fix(rds): proxy target group does not depend on database instances when using writer property for database cluster#31354
mergify[bot] merged 13 commits intoaws:mainfrom
go-to-k:rds-data-proxy-depends

Conversation

@go-to-k
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k commented Sep 7, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31304 .

Reason for this change

Proxy Target Group should depend on and wait for Aurora instances to be ready before creating CloudFormation resource. (see the issue).

Now, the dependency is added when using a legacy instanceProps, but not added when using a writer property.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/proxy.ts#L535-L539

(The cluster has CfnDBInstance directly when using the instanceProps, but it has AuroraClusterInstance with CfnDBInstance as defaultChild when using the writer. So the cluster doesn't have the CfnDBInstance directly in the latter case.)

Description of changes

Added the dependency when using a writer property instead of instanceProps.

Description of how you validated changes

Both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 7, 2024 19:12
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 7, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 7, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k go-to-k marked this pull request as ready for review September 7, 2024 20:31
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 7, 2024 20:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k changed the title fix(rds): proxy target group does not depend on database instances when using writer property fix(rds): proxy target group does not depend on database instances when using writer property for database cluster Sep 7, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 7, 2024
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 9, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 9, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3398fd6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6542207 into aws:main Sep 9, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
@go-to-k go-to-k deleted the rds-data-proxy-depends branch September 9, 2024 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-rds: Proxy Target Group does not depend on Writer Instance

3 participants

@go-to-k @aws-cdk-automation @mrgrain