feat(iot): configure IoT Logging#31352
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@msambol Thank you for your review!! I've addressed your suggestion. |
msambol
left a comment
There was a problem hiding this comment.
Few nits but otherwise looks good.
GavinZZ
left a comment
There was a problem hiding this comment.
Thank you. Left a nit comment and then good to approve.
|
@GavinZZ Thanks always! I've added the link. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31357.
Reason for this change
Cloudformation supports for configuring AWS IoT logging but AWS CDK doesn't support it.
We have to create logging role to enable IoT logging. It is not particularly difficult, but it is user-friendly if IAM roles are implicitly generated by CDK simultaneously.
Description of changes
ILogginginterfaceLoggingPropsLoggingclassCfnLoggingDescription of how you validated changes
Added both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license