Skip to content

feat(kinesisanalytics-flink): support Apache Flink 1.20#31349

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:flink-120
Sep 18, 2024
Merged

feat(kinesisanalytics-flink): support Apache Flink 1.20#31349
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:flink-120

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Sep 7, 2024

Issue # (if applicable)

N/A

Reason for this change

Support new runtime.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-managed-service-apache-flink-1-20/

Description of changes

  • Add Flink 1.20 to enum
  • Improve unit tests and integ test to test all runtime versions

Description of how you validated changes

Ran improved unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 7, 2024 02:54
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 7, 2024
flink.Runtime.FLINK_1_20,
];

test.each(flinkRuntimes)('Flink Application with %s', (runtime) => {
Copy link
Copy Markdown
Contributor Author

@mazyu36 mazyu36 Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved to test all runtimes

flink.Runtime.FLINK_1_20,
];

flinkRuntimes.forEach((runtime) => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved to test all runtimes

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 7, 2024
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const flinkApp = new flink.Application(this, 'Application', {
code: flink.ApplicationCode.fromBucket(bucket, 'my-app.jar'),
runtime: flink.Runtime.FLINK_1_19,
runtime: flink.Runtime.FLINK_1_20,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update row 83 as well for consistency?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Updated.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 16, 2024
GavinZZ
GavinZZ previously approved these changes Sep 18, 2024
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Sep 18, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

2 similar comments
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Sep 18, 2024

@mergify refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed GavinZZ’s stale review September 18, 2024 19:47

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 89e6428
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b3b9aa8 into aws:main Sep 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
@mazyu36 mazyu36 deleted the flink-120 branch September 19, 2024 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants