fix(eks): albController incompatibility with AuthenticationMode.API mode#31258
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
This PR improve the compatibility for
albControllerwithauthenticationMode.APIrelated to #30888
We will address Fargate compatibility in #31267
Reason for this change
authenticationMode.APIis specified, no aws-auth configMap should be createdcluster.awsAuthbecause that would create aws-auth configmap, which is not required inAPImode.Description of changes
Description of how you validated changes
unit tests
authenticationModeinteg test
debugger
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license