chore: update cli integ tests to use sdk v3#31226
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
72b5675 to
059f2d3
Compare
059f2d3 to
d3e7f22
Compare
| }), | ||
| ); | ||
|
|
||
| integTest( |
There was a problem hiding this comment.
Somehow the old and new version of this test ended up in the last update. OOPS. Removing the old flaky one here.
|
Sent to the testing pipeline. Will leave listed as WIP until I've verified that succeeds. |
d3e7f22 to
72b5675
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
72b5675 to
3964cd2
Compare
|
This has succeeded in the test pipeline a few times but I've pushed it with the rebase once again just to cover all my bases. |
|
Ooops. Then rebased it incorrectly. |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
|
Passed the pipeline again. |
scanlonp
left a comment
There was a problem hiding this comment.
Committing these changes.
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license