Skip to content

chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block#31206

Merged
mergify[bot] merged 12 commits intoaws:mainfrom
paulhcsun:kinesis-firehouse-ca-west-1
Sep 4, 2024
Merged

chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block#31206
mergify[bot] merged 12 commits intoaws:mainfrom
paulhcsun:kinesis-firehouse-ca-west-1

Conversation

@paulhcsun
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

Closes #29874

Description of changes

Add missing CIDR block for ca-west-1 + update snapshots.

CIDRs pulled from here.

Description of how you validated changes

integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 23, 2024 19:41
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Aug 23, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 23, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@paulhcsun paulhcsun changed the title fix(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block Aug 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 23, 2024 19:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

jfuss
jfuss previously requested changes Aug 27, 2024
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27/27"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 40.176.98.192/27. There is an extra /27 at the end.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but this keeps getting automatically updated with the extra /27 and overriding my changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized I was not updating the value in the correct place. It should be fixed now.

@paulhcsun paulhcsun marked this pull request as ready for review August 29, 2024 20:48
@paulhcsun
Copy link
Copy Markdown
Contributor Author

oops one more integ test snapshot to update

@HBobertz HBobertz assigned HBobertz and unassigned HBobertz Sep 4, 2024
@paulhcsun
Copy link
Copy Markdown
Contributor Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 4, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@paulhcsun paulhcsun requested a review from jfuss September 4, 2024 20:58
@paulhcsun paulhcsun dismissed jfuss’s stale review September 4, 2024 20:59

snapshot updated

@paulhcsun
Copy link
Copy Markdown
Contributor Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 4, 2024

update

☑️ Nothing to do

Details
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 399c3d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 125ca2f into aws:main Sep 4, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-kinesisfirehose-alpha: Needs support for ca-west-1

5 participants