feat(codebuild): macOS codebuild support#31203
Conversation
e39c703 to
788abff
Compare
GavinZZ
left a comment
There was a problem hiding this comment.
Nice work! Excited to see this supported.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| if (buildEnvironment.computeType != ComputeType.MEDIUM) { | ||
| errors.push('Mac images only support medium compute type'); | ||
| } |
There was a problem hiding this comment.
@alanxluc .. I think this type of validation is that there is a big probability to change, and I think it should not be part of CDK validations.
There was a problem hiding this comment.
Ack, will revise. Is the other validation good to keep?
There was a problem hiding this comment.
yes, they look reasonable. Thanks @alanxluc for your contribution :)
moelasmar
left a comment
There was a problem hiding this comment.
I left one minor comment
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31170.
Reason for this change
CodeBuild recently added support for Mac builds. https://aws.amazon.com/about-aws/whats-new/2024/08/aws-codebuild-mac-builds/
The CDK can to be extended to support Mac CodeBuild fleets, as well as using those fleets in CodeBuild projects.
Description of changes
MAC_ARMvalue to EnvironmentType enumMacBuildImageto project.tsAll design decisions were made by following the previous precedent set by
LinuxBuildImageandWindowsBuildImage.Description of how you validated changes
I added unit tests and integration tests for
MacBuildImage. I ensured that the CDK was able to build, and that the output CloudFormation stack had the correct resources. I also successfully built the Codebuild project that was deployed.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license