feat(efs): allow AccessPoint to set client token#31184
feat(efs): allow AccessPoint to set client token#31184mergify[bot] merged 5 commits intoaws:mainfrom perrylson:add-client-token-property-access-point
Conversation
badmintoncryer
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I've added some comments.
badmintoncryer
left a comment
There was a problem hiding this comment.
Thanks! I am proposing just one refactor, but I approve it.
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, just one minor update to the validation part to make it clearer.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
The CfnAccessPoint construct supports client token specification. However, the current L2 implementation of AccessPoint does not support this property.
The
disable-update-workflowoption was needed when running the updated integration test.Description of changes
Added the
clientTokenprop to the existing props of AccessPoint.Description of how you validated changes
Validated with unit and integration testing.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license