chore: set LogGroup removal policy of all CDK-vended custom resources with CustomResourceConfig#31149
Merged
mergify[bot] merged 8 commits intoaws:mainfrom Aug 21, 2024
Merged
Conversation
comcalvi
previously requested changes
Aug 19, 2024
Contributor
comcalvi
left a comment
There was a problem hiding this comment.
Nice work! This is almost ready to merge 🙂
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Show resolved
Hide resolved
comcalvi
previously requested changes
Aug 20, 2024
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts
Show resolved
Hide resolved
comcalvi
previously requested changes
Aug 20, 2024
...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts
Outdated
Show resolved
Hide resolved
comcalvi
reviewed
Aug 21, 2024
comcalvi
approved these changes
Aug 21, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
CDK vended custom resources LogGroup are left to retain.
Modify all CDK-vended custom resources with
CustomResourceConfigand to modify LogGroup removal policy withaddRemovalPolicymethod.CustomResourceConfig.of(app).addRemovalPolicy(cdk.RemovalPolicy.DESTROY);Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license