fix(eks): eks.AccessEntryType.STANDARD maps to a wrong value#31147
fix(eks): eks.AccessEntryType.STANDARD maps to a wrong value#31147mergify[bot] merged 6 commits intoaws:mainfrom naaandor:eks-correct-access-entry-type
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
|
Thank you for the heads-up.
Looks like we need to get the doc fixed. Internal tracking: V1497605545 |
|
Hi @ncsereoka , thanks for raising the PR. Could you please add an integration test to make sure the new value can be deployed? |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
xazhao
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the integration test
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
☑️ Nothing to doDetails
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31147 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 105 105
Lines 7164 7164
Branches 1311 1311
=======================================
Hits 5530 5530
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Tried making use of the
eks.AccessEntryconstruct, with theeks.AccessEntryType.STANDARDas accessEntryType, but the stack deployment failed with the following error:AccessEntry type must be one of [EC2_LINUX, EC2_WINDOWS, FARGATE_LINUX, STANDARD].Seems like 'Standard' is not alright, suggested also by
eksctldocs.If this is the case, documentation in the following places also needs to be corrected:
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license