Skip to content

chore(applicationautoscaling): add missing PredefinedMetricType enum values#31115

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
shahks:31113
Aug 19, 2024
Merged

chore(applicationautoscaling): add missing PredefinedMetricType enum values#31115
mergify[bot] merged 3 commits intoaws:mainfrom
shahks:31113

Conversation

@shahks
Copy link
Copy Markdown
Contributor

@shahks shahks commented Aug 14, 2024 •
edited by moelasmar
Loading

Issue # (if applicable)

Closes #31113

Reason for this change

There are three PredefinedMetricType values missing from the enum:

  • SageMakerInferenceComponentConcurrentRequestsPerCopyHighResolution
  • SageMakerVariantConcurrentRequestsPerModelHighResolution
  • WorkSpacesAverageUserSessionsCapacityUtilization

https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html

Description of changes

Adds the missing enums

Description of how you validated changes

Added unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 14, 2024 20:23
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 14, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shahks
Copy link
Copy Markdown
Contributor Author

shahks commented Aug 14, 2024

updates to README file and integ test file is not necessary as it's only adding enums.

@moelasmar moelasmar changed the title feat(applicationautoscaling): add missing PredefinedMetricType enum v... feat(applicationautoscaling): add missing PredefinedMetricType enum values Aug 14, 2024
@moelasmar moelasmar changed the title feat(applicationautoscaling): add missing PredefinedMetricType enum values chore(applicationautoscaling): add missing PredefinedMetricType enum values Aug 14, 2024
moelasmar
moelasmar previously requested changes Aug 14, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 14, 2024 20:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed moelasmar’s stale review August 14, 2024 21:34

Pull request has been modified.

@shahks shahks requested a review from moelasmar August 14, 2024 21:41
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 14, 2024
moelasmar
moelasmar previously approved these changes Aug 17, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed moelasmar’s stale review August 18, 2024 15:43

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 18, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 79ef624
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 18, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c1c800e into aws:main Aug 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@moelasmar moelasmar moelasmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws_applicationautoscaling: Enable SageMaker high resolution predefined metric

3 participants

@shahks @aws-cdk-automation @moelasmar