fix(s3): bucket notifications in owning stack deletes bucket notifications from other stacks#31091
Conversation
…ns from other stacks
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource.ts
Outdated
Show resolved
Hide resolved
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30607.
Reason for this change
There's a bug reported in the Github issue that bucket notifications in owing stack will remove all notifications added in imported stack. This is because we treated the bucket as
managedhence we use bucket notifications in that stack as source of truth.In the
unmanagedpath, we already filtered out external notifications it should handle both scenarios when the bucket is managed or unmanaged.Description of changes
Always set
Managedproperty to false when the feature flag is enabled. Here we introduce a feature flag to prevent it breaking current customers.Description of how you validated changes
Added unit tests. Integrations test can't validate this change because we need to deploy twice to actually see the change.
Also tested manually.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license