chore(doc): improve the doc on DockerImageFunction for cross-platform bundling#31053
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Aug 28, 2024
Merged
Conversation
gracelu0
suggested changes
Aug 12, 2024
Contributor
gracelu0
left a comment
There was a problem hiding this comment.
Thanks Pahud! Small typo to fix, otherwise looks good to me.
Co-authored-by: Grace Luo <54298030+gracelu0@users.noreply.github.com>
Contributor
Author
|
Just fixed the typo. Thank you @gracelu0 |
gracelu0
approved these changes
Aug 28, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31048
Reason for this change
Per discussed #31048 (comment), the
architecturewould still be required when bundlingX86_64DockerImageFunction from aarm64machine like a Macbook with arm64 chip as it explicitly pass the--platformargument todocker build, which is required in this use case.Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license