Skip to content

fix(lambda-event-source): allow dynamodb filtering on boolean value#31011

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
mellevanderlinde:dynamodb_filter_bool
Aug 28, 2024
Merged

fix(lambda-event-source): allow dynamodb filtering on boolean value#31011
mergify[bot] merged 4 commits intoaws:mainfrom
mellevanderlinde:dynamodb_filter_bool

Conversation

@mellevanderlinde
Copy link
Copy Markdown
Contributor

@mellevanderlinde mellevanderlinde commented Aug 2, 2024

Issue # (if applicable)

Closes #30734

Reason for this change

Filtering on boolean values was not possible

Description of changes

lambda.FilterRule.isEqual(...) now accepts boolean values

Description of how you validated changes

Added a unit test and integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2024 16:23
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 2, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 2, 2024
lpizzinidev
lpizzinidev approved these changes Aug 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 4, 2024
@github-actions github-actions bot mentioned this pull request Aug 5, 2024
Closed
gracelu0
gracelu0 previously requested changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mellevanderlinde , thank you for your contribution! Could you add a section/example to the README for filtering please? It will help CDK users find this feature easier.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 13, 2024
@mergify mergify bot dismissed gracelu0’s stale review August 26, 2024 14:44

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 26, 2024
@mellevanderlinde
Copy link
Copy Markdown
Contributor Author

mellevanderlinde commented Aug 26, 2024

@gracelu0 I've updated the README!

GavinZZ
GavinZZ previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding the README changes. Approving on behalf of Grace since her feedback has been addressed.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 27, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Aug 27, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 27, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-regression-labeler.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review August 28, 2024 00:06

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 28, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 625765c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9946ab0 into aws:main Aug 28, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
@mellevanderlinde mellevanderlinde deleted the dynamodb_filter_bool branch August 28, 2024 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

@gracelu0 gracelu0 gracelu0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lambda-eventsources: DynamoDB, unable to filter for bool values

5 participants

@mellevanderlinde @GavinZZ @aws-cdk-automation @lpizzinidev @gracelu0