feat(kms): support KEY_AGREEMENT for keyUsage#30993
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| KeySpec.SYMMETRIC_DEFAULT, | ||
| KeySpec.SM2, | ||
| ], | ||
| [KeyUsage.KEY_AGREEMENT]: [ |
There was a problem hiding this comment.
I confirmed from the documentation and management console that only the following keySpecs are supported, and added the unsupported ones to the denyList.
- For asymmetric KMS keys with NIST-recommended elliptic curve key pairs, specify SIGN_VERIFY or KEY_AGREEMENT.
- For asymmetric KMS keys with SM2 key pairs (China Regions only), specify ENCRYPT_DECRYPT, SIGN_VERIFY, or KEY_AGREEMENT.
|
Exemption Request: I think updating the README is unnecessary, as this only involves adding a value to an enum. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Leo10Gama
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30989
Reason for this change
To support
KEY_AGREEMENTfor KeyUsage.Description of changes
KEY_AGREEMENTto KeyUsage enumDescription of how you validated changes
Add unit test and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license