Skip to content

chore(apigateway): enhance code arounds method authorizers#30978

Merged
mergify[bot] merged 5 commits intomainfrom
update_method_authorizer
Jul 30, 2024
Merged

chore(apigateway): enhance code arounds method authorizers#30978
mergify[bot] merged 5 commits intomainfrom
update_method_authorizer

Conversation

@GavinZZ
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ commented Jul 29, 2024

Issue # (if applicable)

Reason for this change

Add comments and enhance the code around method authorizers.

Description of changes

No behavioural change, should only include comments, variables name update and re-ordering.

Description of how you validated changes

All existing tests pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2024 20:26
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 29, 2024
@GavinZZ GavinZZ marked this pull request as ready for review July 29, 2024 21:03
Copy link
Copy Markdown
Contributor

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit, otherwise LGTM!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 29, 2024
@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label Jul 29, 2024
Copy link
Copy Markdown
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 29, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3675b1b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label Jul 30, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 439feaf into main Jul 30, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the update_method_authorizer branch July 30, 2024 23:45
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
@GavinZZ GavinZZ added p1 and removed p2 labels Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants