chore: lock conversations on closed issues and PRs with message#30941
chore: lock conversations on closed issues and PRs with message#30941mergify[bot] merged 3 commits intomainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
it looks good to me. The only thing is missed, and I do not think we need to add it as GH workflow is to do lock all old closed issues and PRs, as this workflow will work only for newly closed issues or prs |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
| message: | | ||
| Comments on closed issues and PRs are hard for our team to see. | ||
| If you need help, please open a new issue that references this one. | ||
| If you wish to keep having a conversation with other community members under this issue feel free to do so. |
There was a problem hiding this comment.
I think this line should be removed, I think community will not be able to add comments
There was a problem hiding this comment.
sorry I missed this line while reviewing the PR
There was a problem hiding this comment.
Oh good point. Let me remove it.
Issue # (if applicable)
Reason for this change
Lock conversations on closed issues and PRs to make sure important comments are not left on closed items and no one would be able to see it. Force people to create new issues instead.
Description of changes
Lock conversations.
Description of how you validated changes
Tested in a forked repo and it works correctly.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license