docs(eks): add documentation about add-ons#30815
Conversation
0c8cfd0 to
46604a0
Compare
scanlonp
left a comment
There was a problem hiding this comment.
Good find. Not sure why this was not included, maybe because it was an implementation detail for EKS Pod Identity Agent, but probably should be in the readme.
Is there a reason for the location of this section? Just curious how it fits with the other resources.
Also lets add a link to the section from the table of contents.
|
@scanlonp Thank you for your review!
There isn't any specific reason, but could you please let me know if there's a more appropriate place for the description? |
|
I think it's fine where it is. No real preference! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
None
Reason for this change
Addon L2 construct is added by #30576 but there is no documentation about it in the README.md.
Description of changes
Add Add-ons documentation to README.md
Description of how you validated changes
None
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license