fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag)#30706
Merged
mergify[bot] merged 32 commits intoaws:mainfrom Jul 2, 2024
Conversation
…nts-notifications
This was referenced Jul 1, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
approved these changes
Jul 2, 2024
Member
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thank you so much for the effort!!
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #28915
Reason for this change
Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.
Description of changes
We fixed the hashing logic used to identify old vs external S3 event notifications
Description of how you validated changes
Manually tested, integration and unit tested the changes
yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license