Skip to content

revert: fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag)#30699

Merged
mergify[bot] merged 3 commits intomainfrom
revert-30610-feature/s3-lambda-events-notifications
Jun 27, 2024
Merged

revert: fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag)#30699
mergify[bot] merged 3 commits intomainfrom
revert-30610-feature/s3-lambda-events-notifications

Conversation

@GavinZZ
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ commented Jun 27, 2024

Reverts #30610 due to Feature flags issues

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2024 20:32
@github-actions github-actions bot added the p2 label Jun 27, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2024
@GavinZZ GavinZZ marked this pull request as ready for review June 27, 2024 20:33
See https://github.com/aws/aws-cdk/issues/28915 for more details.
Enabling this flag allows you to successfully delete existing S3 event notifications.
`,
introducedIn: { v2: '2.145.0' },
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introducedIn: { v2: 'V2NEXT' },

| Since | Default | Recommended |
| ----- | ----- | ----- |
| (not in v1) | | |
| 2.145.0 | `false` | `true` |
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 27, 2024
Copy link
Copy Markdown
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 27, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 35c07e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2869aaa into main Jun 27, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the revert-30610-feature/s3-lambda-events-notifications branch June 27, 2024 23:11
This was referenced Jul 1, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants