Skip to content

feat(ec2): add g6 instance#30693

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
mellevanderlinde:ec2_g6_support
Jul 18, 2024
Merged

feat(ec2): add g6 instance#30693
mergify[bot] merged 4 commits intoaws:mainfrom
mellevanderlinde:ec2_g6_support

Conversation

@mellevanderlinde
Copy link
Copy Markdown
Contributor

@mellevanderlinde mellevanderlinde commented Jun 27, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30683

Reason for this change

G6 instances are not yet supported by CDK L2

Description of changes

Added G6 instance class

Description of how you validated changes

Added g6 to existing unit test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2024 13:48
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jun 27, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 27, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mellevanderlinde
Copy link
Copy Markdown
Contributor Author

mellevanderlinde commented Jun 27, 2024 •
edited
Loading

Would this small change qualify for an "Exemption Request"? An integration test might not be required for adding an instance class

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 27, 2024
msambol
msambol approved these changes Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@msambol msambol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you please change the title to feat instead of fix.

@msambol
Copy link
Copy Markdown
Contributor

msambol commented Jun 28, 2024

Would this small change qualify for an "Exemption Request"? An integration test might not be required for adding an instance class

Yeah, no integration test is needed here.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 28, 2024
@mellevanderlinde mellevanderlinde changed the title fix(ec2): add g6 instance feat(ec2): add g6 instance Jun 28, 2024
This was referenced Jul 1, 2024
Closed
Closed
scanlonp
scanlonp approved these changes Jul 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @mellevanderlinde!

This does not need an integ test or readme update, I'll throw the labels on.

@scanlonp scanlonp added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jul 18, 2024
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself July 18, 2024 17:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 18, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 18, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d793ce5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 90a41d5 into aws:main Jul 18, 2024
@mellevanderlinde mellevanderlinde deleted the ec2_g6_support branch July 19, 2024 07:01
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@msambol msambol msambol approved these changes

@scanlonp scanlonp scanlonp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ec2: Need G6 EC2 Instance support

4 participants

@mellevanderlinde @msambol @aws-cdk-automation @scanlonp