fix(custom-resources): provider framework will always log all data including confidential data#30689
Conversation
22df5ac to
8d38c20
Compare
paulhcsun
left a comment
There was a problem hiding this comment.
Minor changes, otherwise this looks good to me.
packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/cfn-response.ts
Show resolved
Hide resolved
paulhcsun
left a comment
There was a problem hiding this comment.
noice @Mergifyio update
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
e37dede to
b5d694c
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30275.
Reason for this change
When using a Provider to create a custom resource, the request and response objects are logged by the provider function. There is no apparent way to prevent or redact this logging, resulting in secrets being logged if returned in the custom resource's Data object. By extension, if secret values are passed in the resource's ResourceProperties they will be logged as well.
Description of changes
Allow
NoEchofields to mask the data response to*****.Description of how you validated changes
Integ test covering this and verifeid in the log stream that
redactedis included in the message.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license