Skip to content

chore(elasticloadbalancingv2): specific 5XX CloudWatch metrics for ALB#30659

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
sakurai-ryo:add-http-code-elb
Jul 24, 2024
Merged

chore(elasticloadbalancingv2): specific 5XX CloudWatch metrics for ALB#30659
mergify[bot] merged 6 commits intoaws:mainfrom
sakurai-ryo:add-http-code-elb

Conversation

@sakurai-ryo
Copy link
Copy Markdown
Contributor

@sakurai-ryo sakurai-ryo commented Jun 25, 2024 •
edited
Loading

Reason for this change

ALB supports metrics for specific load balancer generated 5XX level error metrics.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-cloudwatch-metrics.html

However, they are currently not included in HttpCodeElb, so the metrics.httpCodeElb method is not available and metrics.custom must be used.

let alb: IApplicationLoadBalancer;
alb.metrics.httpCodeElb(HttpCodeElb.ELB_5XX_COUNT); // we can do this
alb.metrics.httpCodeElb(HttpCodeElb.ELB_500_COUNT); // currently we cannot do this
alb.metrics.custom("HTTPCode_ELB_500_Count");

Adding the metric names to HttpCodeElb makes it easier to understand as it can be configured in the same way as HTTPCode_ELB_5XX_Count.

Description of changes

Add metrics names to HttpCodeElb.

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2024 09:22
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels Jun 25, 2024
This was referenced Jul 1, 2024
Closed
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 3, 2024
paulhcsun
paulhcsun previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@paulhcsun paulhcsun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @sakurai-ryo! Could you add some test cases as well?

@paulhcsun paulhcsun self-requested a review July 3, 2024 20:36
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra TheRealAmazonKendra added the pr/do-not-merge This PR should not be merged at this time. label Jul 3, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 3, 2024
@mergify mergify bot dismissed paulhcsun’s stale review July 8, 2024 12:52

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 8, 2024
@sakurai-ryo
Copy link
Copy Markdown
Contributor Author

sakurai-ryo commented Jul 8, 2024

@paulhcsun
Thanks for your review!
I added the unit test.

@paulhcsun paulhcsun removed the pr/do-not-merge This PR should not be merged at this time. label Jul 24, 2024
paulhcsun
paulhcsun previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @sakurai-ryo!

And thanks for the review @go-to-k!

@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Jul 24, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Jul 24, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

update

☑️ Nothing to do

Details
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@mergify mergify bot dismissed paulhcsun’s stale review July 24, 2024 18:43

Pull request has been modified.

paulhcsun
paulhcsun previously approved these changes Jul 24, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 24, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Jul 24, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/lock-issue-pr-with-message.yml without workflows permission

@mergify mergify bot dismissed paulhcsun’s stale review July 24, 2024 20:28

Pull request has been modified.

@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Jul 24, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

update

☑️ Nothing to do

Details
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 24, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c0c9ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7998eeb into aws:main Jul 24, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2024 •
edited by GavinZZ
Loading

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@go-to-k go-to-k go-to-k approved these changes

@paulhcsun paulhcsun paulhcsun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sakurai-ryo @paulhcsun @aws-cdk-automation @go-to-k @TheRealAmazonKendra