feat(pipes-targets): add EventBridge by msambol · Pull Request #30654 · aws/aws-cdk

msambol · 2024-06-24T22:45:17Z

Add EventBridge event bus as a Pipes target.

nmussy

The file names should also be camel cased, s/eventBridge/event-bridge/

packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts

msambol · 2024-06-25T14:55:02Z

@nmussy Updated. Great feedback as always. Thanks!

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

aws-cdk-automation · 2024-06-29T00:11:01Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

kaizencc

Hi @msambol sorry for the long delay, have a few comment before my stamp of approval!

packages/@aws-cdk/aws-pipes-targets-alpha/README.md

kaizencc · 2024-09-04T19:20:39Z

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

+export class EventBridgeTarget implements ITarget {
+  private eventBus: IEventBus;
+  private eventBridgeParameters?: EventBridgeTargetParameters;
+  public readonly targetArn: string;


Suggested change

public readonly targetArn: string;

public readonly targetArn: string;

in addition to the spacing since this is a public prop it should have a docstring... shouldn't the linter have picked up on that?

@kaizencc I think because it's here ? https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-pipes-alpha/lib/target.ts#L19-L22. not entirely sure.

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

Pull request has been modified.

msambol · 2024-09-05T15:30:27Z

@kaizencc – Update per your feedback. Thanks for the review!

msambol · 2024-09-24T02:51:04Z

@kaizencc mind giving this another pass?

msambol · 2024-09-28T02:35:08Z

@kaizencc I updated the integration test to incorporate feedback by @moelasmar on #30756.

msambol · 2024-10-04T00:57:13Z

@Leo10Gama Could we get this one in next?

Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>

Leo10Gama

Thanks for the contribution! Aside from a few minor typos, it looks pretty good to me

packages/@aws-cdk/aws-pipes-targets-alpha/README.md

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

packages/@aws-cdk/aws-pipes-targets-alpha/test/event-bridge.test.ts

Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

…st.ts Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

aws-cdk-automation · 2024-10-07T20:40:02Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7aa72b0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Leo10Gama

LGTM, thanks again!

mergify · 2024-10-07T20:54:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-10-07T20:54:49Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team June 24, 2024 22:45

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 24, 2024

msambol force-pushed the pipes-targets-eventbridge branch 2 times, most recently from 5cf3b4f to 1bcc300 Compare June 25, 2024 00:42

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024

nmussy suggested changes Jun 25, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024

nmussy reviewed Jun 25, 2024

View reviewed changes

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts Outdated Show resolved Hide resolved

msambol force-pushed the pipes-targets-eventbridge branch from 06f4d5d to 6eaf6c5 Compare June 29, 2024 01:57

This was referenced Jul 1, 2024

Monthly PR metrics report #30715

Closed

Weekly PR metrics report #30720

Closed

pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024

kaizencc previously requested changes Sep 4, 2024

View reviewed changes

msambol force-pushed the pipes-targets-eventbridge branch from de40e78 to d7912d1 Compare September 5, 2024 02:36

msambol force-pushed the pipes-targets-eventbridge branch from 635d50b to f4575d5 Compare September 5, 2024 15:51

msambol force-pushed the pipes-targets-eventbridge branch from fd16301 to 32a16e1 Compare September 27, 2024 23:57

msambol force-pushed the pipes-targets-eventbridge branch from fe76476 to f7d14ef Compare October 4, 2024 00:56

msambol added 4 commits October 5, 2024 21:48

feat(pipes-targets): add EventBridge

f9b39f5

Trigger build

b5b78df

fix integ test stack name

49da10d

fix integ test name

31f6199

msambol and others added 17 commits October 5, 2024 21:48

trigger build

f255aa6

fix export

80394de

Fix readme

be50ace

Add feedback from @nmussy

796f9d5

fix import

718a6a9

Update packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

b759237

Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>

Update index.ts

5374d3d

Add feedback from @kaizencc

2c48cf4

Fix import order

fb0d9c7

Fix readme

49143aa

Fix readme (again)

2c2b9e7

Fix verbiage in test case

d896182

Rebase, update integration test, fix readme

9e9330e

fix grammer in readme

7f45d65

Update integration test to use SqsSource

e96023b

fix readme

e3ae101

Add sources as dev dep

a4de2cb

msambol force-pushed the pipes-targets-eventbridge branch from f7d14ef to a4de2cb Compare October 6, 2024 04:48

Leo10Gama reviewed Oct 7, 2024

View reviewed changes

msambol and others added 5 commits October 7, 2024 11:51

Update packages/@aws-cdk/aws-pipes-targets-alpha/README.md

700de45

Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

Update packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts

ccf58a4

Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

Update packages/@aws-cdk/aws-pipes-targets-alpha/test/event-bridge.te…

c50a807

…st.ts Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

Update packages/@aws-cdk/aws-pipes-targets-alpha/test/event-bridge.te…

a85c54e

…st.ts Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>

Merge branch 'main' into pipes-targets-eventbridge

7aa72b0

Leo10Gama approved these changes Oct 7, 2024

View reviewed changes

mergify bot merged commit 842f49a into aws:main Oct 7, 2024

github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024

	public readonly targetArn: string;
	public readonly targetArn: string;

Conversation

msambol commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nmussy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msambol commented Jun 25, 2024

Uh oh!

Uh oh!

aws-cdk-automation commented Jun 29, 2024

Uh oh!

kaizencc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaizencc Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

kaizencc Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

msambol Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

msambol commented Sep 5, 2024

Uh oh!

msambol commented Sep 24, 2024

Uh oh!

msambol commented Sep 28, 2024

Uh oh!

msambol commented Oct 4, 2024

Uh oh!

Leo10Gama left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aws-cdk-automation commented Oct 7, 2024

AWS CodeBuild CI Report

Uh oh!

Leo10Gama left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

msambol commented Jun 24, 2024 •

edited

Loading