feat(events): dead letter queue for an Event Bus#30628
feat(events): dead letter queue for an Event Bus#30628mergify[bot] merged 22 commits intoaws:mainfrom
Conversation
|
Small nits re: the naming, otherwise LGTM. |
|
@msambol Thank you for your review!! I've addressed your comments. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
2 similar comments
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
@msambol Hi, I've fixed this PR. Could you please re-review this? |
mazyu36
left a comment
There was a problem hiding this comment.
LGTM.
A community review was already done, but since there had been no activity for a long time, I reviewed it again
|
@mazyu36 Thank you very much for your kindness!! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
moelasmar
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30531.
Reason for this change
EventBus L2 construct doesn't support for configuring dead letter queue.
Description of changes
Add
deadLetterQueueprop toEventBusPropsDescription of how you validated changes
Add both unit and integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license