feat(apprunner): support vpc ingress connection#30623
feat(apprunner): support vpc ingress connection#30623mergify[bot] merged 14 commits intoaws:mainfrom
Conversation
5b3e3e1 to
6e66ff9
Compare
|
@Mergifyio update |
☑️ Nothing to doDetails
|
|
|
||
| public constructor(scope: Construct, id: string, props: VpcIngressConnectionProps) { | ||
| super(scope, id, { | ||
| physicalName: props.vpcIngressConnectionName, |
There was a problem hiding this comment.
Did you check if it deploys with vpcIngressConnectionName: undefined?
If not, we should lazily generate one.
There was a problem hiding this comment.
Thank you. I tried deploying with vpcIngressConnectionName: undefined, and I was able to deploy without any issues.
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
|
@lpizzinidev |
Pull request has been modified.
|
@paulhcsun |
paulhcsun
left a comment
There was a problem hiding this comment.
Nice work @mazyu36! Thanks for reviewing @lpizzinidev!
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #22850.
Reason for this change
To support VPC Ingress Connection for making App Runner Service private and only accessible from within a VPC.
Description of changes
isPubliclyAccessibleproperty to theServiceclassVpcIngressConnectionclassDescription of how you validated changes
Add unit tests and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license