feat(redshift): supports excludeCharacters settings for DatabaseSecret#30563
feat(redshift): supports excludeCharacters settings for DatabaseSecret#30563mergify[bot] merged 6 commits intoaws:mainfrom
Conversation
badmintoncryer
left a comment
There was a problem hiding this comment.
Thank you for your PR! I added only a nit comment.
| testCases: [new RedshiftEnv(app, 'redshift-exclude-characters-integ')], | ||
| }); | ||
|
|
||
| app.synth(); |
There was a problem hiding this comment.
nit: it is not essential
| app.synth(); |
There was a problem hiding this comment.
Thanks.
I've removed.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #26847.
Reason for this change
In the case of passwords generated by DatabaseSecret, there may be a need to exclude certain characters.
The original issue was to exclude the backtick character from passwords.
However, the current default value of
excludeCharacters,'"@/\ '', matches the characters that are not supported in Redshift (docs).Instead of including the backtick in the default value of
excludeCharacters, it was considered appropriate to make it configurable.Description of changes
Add
excludeCharactersproperty to specify characters to not include in generated passwords.Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license