feat(dynamodb): enable contributor insights for global secondary index#30560
feat(dynamodb): enable contributor insights for global secondary index#30560mergify[bot] merged 14 commits intoaws:mainfrom
Conversation
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
badmintoncryer
left a comment
There was a problem hiding this comment.
Thank you for your PR! I've added some small comments.
...esting/framework-integ/test/aws-dynamodb/test/integ.dynamodb.contirubtor-insights-for-gsi.ts
Outdated
Show resolved
Hide resolved
| import { IntegTest } from '@aws-cdk/integ-tests-alpha'; | ||
|
|
||
| // CDK parameters | ||
| const STACK_NAME = 'aws-cdk-dynamodb-contributor-insights-for-gis'; |
There was a problem hiding this comment.
What is the meaning of gis? If it means global secondary index, it is better to use gsi.
There was a problem hiding this comment.
As you pointed out, it was a mistake.
I have corrected it.
| partitionKey: GSI_PARTITION_KEY, | ||
| }); | ||
|
|
||
| new IntegTest(app, 'aws-cdk-dynamodb-contributor-insights-for-gis-test', { |
There was a problem hiding this comment.
Just like above, I'm only concerned about gis.
Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…st/integ.dynamodb.contirubtor-insights-for-gsi.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
072b75e to
716c60f
Compare
|
@badmintoncryer |
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thanks for the consistent contributions!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #15671 .
Reason for this change
To enable contributor insights for a specific global secondary index.
This feature is supported in CFn.
Description of changes
Add
contributorInsightsEnabledproperty to theGlobalSecondaryIndexPropsinTable.In AWS::DynamoDB::GlobalTable GlobalSecondaryIndex,
ContributorInsightsSpecificationdoes not exist.So I didn't change
TableV2.Description of how you validated changes
Add unit test and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license