fix(cloudformation-include): can't use CFN intrinsics in Tags#30515
fix(cloudformation-include): can't use CFN intrinsics in Tags#30515mergify[bot] merged 9 commits intomainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
This looks good but could you add an additional test for an intrinsic that uses other intrinsics within it or just a more complex one in general?
|
@TheRealAmazonKendra Any chance we get this merged as-is to fix the issue for the simple case at the very least? |
Comments have been addressed
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #27594.
Reason for this change
Templates that use intrinsics in resource Tags cannot be used with CFN Include.
Description of changes
Modifed the CFN Parser to not choke on Intrinsics found in resource Tags.
Description of how you validated changes
Unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license