chore(glue): support ConnectionType.MARKETPLACE and ConnectionType.CUSTOM#30395
chore(glue): support ConnectionType.MARKETPLACE and ConnectionType.CUSTOM#30395mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks 👍
Could you also add a link to CFN documentation to the documentation of the ConnectionType class for context?
* If you need to use a connection type that doesn't exist as a static member, you
* can instantiate a `ConnectionType` object, e.g: `new ConnectionType('NEW_TYPE')`.
*
* @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-connection-connectioninput.html#cfn-glue-connection-connectioninput-connectiontype
*/
export class ConnectionType {|
@lpizzinidev |
|
We have a team doing a refactor of this module so we will need them to review this to ensure it doesn't cause conflicts there. Adding a do-not-merge label in the meantime. |
|
Refactor PR linked here: #30833 |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@TheRealAmazonKendra FYI I'm removing the |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
MARKETPLACEandCUSTOMare not supported in the current L2 Construct. (SFTPis also missing, but it is not supported at the moment.)https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-connection-connectioninput.html#cfn-glue-connection-connectioninput-connectiontype
Description of changes
Add missing connection types.
Description of how you validated changes
I determined that no testing was needed since this was only an addition of connection types.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license