Skip to content

feat(fsx): support HDD storage type for a Lustre file systems#30207

Merged
mergify[bot] merged 33 commits intoaws:mainfrom
badmintoncryer:storageTypeForLuster
Oct 10, 2024
Merged

feat(fsx): support HDD storage type for a Lustre file systems#30207
mergify[bot] merged 33 commits intoaws:mainfrom
badmintoncryer:storageTypeForLuster

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented May 15, 2024

Issue # (if applicable)

Closes #30206.

Reason for this change

AWS FSx for Luster file systems supports HDD storage type and LusterFileSystem construct cannot configure it.

Description of changes

  • Add storageType for fsx.FileStstemProps
    • For future expansion, storageType is added not to LusterFileSystemProps but to FileSystemProps because HDD storage is also supported by Windows file systems.
  • Update the validation of the props below to address the HDD storage type.
    • LusterConfiguration.perUnitStorageThroughput
    • FileSystemProps.storageCapacityGiB

Description of how you validated changes

Added both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels May 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2024 13:10
@badmintoncryer badmintoncryer force-pushed the storageTypeForLuster branch from 75a2e79 to f6ed95d Compare May 15, 2024 13:10
aws-cdk-automation
aws-cdk-automation previously requested changes May 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer changed the title feat(fsx): HDD storage for Lustre file systems feat(fsx): support HDD storage type for Lustre file systems May 15, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 15, 2024 13:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2024
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
This was referenced May 28, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 23, 2024

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@badmintoncryer badmintoncryer changed the title feat(fsx): support HDD storage type for Lustre file systems feat(fsx): support HDD storage type for a Lustre file systems Jun 24, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jun 24, 2024
lpizzinidev
lpizzinidev suggested changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left some comments for adjustments

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 1, 2024
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-fsx/lib/file-system.ts
2cb12cb 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
badmintoncryer and others added 5 commits August 5, 2024 22:44
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Aug 5, 2024

@lpizzinidev Thank you for your review! I've addressed your comments.

lpizzinidev
lpizzinidev approved these changes Aug 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 6, 2024
GavinZZ
GavinZZ approved these changes Oct 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's a lot of validations but I think you handled them nicely.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 10, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a095800
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2d9aefb into aws:main Oct 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
@badmintoncryer badmintoncryer deleted the storageTypeForLuster branch October 10, 2024 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fsx: HDD storageType for luster file system

4 participants

@badmintoncryer @aws-cdk-automation @lpizzinidev @GavinZZ