feat(ecs-patterns): dualstack NLB#30069
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
6068495 to
55d81d1
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/network-load-balanced-service-base.ts
Show resolved
Hide resolved
|
@badmintoncryer Thanks for the PR, just FYI that there're conflicts to resolve. |
10e5d63 to
8f0b595
Compare
|
@GavinZZ Thanks for the review. I've resolved all conflicts. |
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #29614.
Reason for this change
Dualstack NLB is not supported in
NetworkLoadBalancedServiceBase.Description of changes
ipAddressTypetoNetworkLoadBalancedServiceBaseProps.IpAddressType.Ipv4Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license