fix(elasticloadbalancingv2): crossZoneEnabled does not support false for ALB#29907
Merged
mergify[bot] merged 8 commits intoaws:mainfrom Apr 19, 2024
Merged
fix(elasticloadbalancingv2): crossZoneEnabled does not support false for ALB#29907mergify[bot] merged 8 commits intoaws:mainfrom
mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
1 task
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Apr 22, 2024
This was referenced May 23, 2024
This was referenced Jun 22, 2024
Collaborator
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29866
Reason for this change
crossZoneEnabledis not well handled when it'sfalsewith ALB. Because:false, it will not pass down to the L1 and won't throw any error as ALB does not support being disabled. It just silently ignore it.falsefor NLB, the L1 attribute will beundefined, which is having the same result but it should be explicitly set asfalsein L1.This PR covers the following cases:
crossZoneEnabledistrue,load_balancing.cross_zone.enabledshould betrue.crossZoneEnabledisfalse,load_balancing.cross_zone.enabledshould befalse, rather thanundefined.crossZoneEnabledisfalsewith ALB, cdk throws an error because ALB does not support disabling it per doc description.trueorfalse.undefinedfor ALB or NLB.crossZoneEnabledprop.Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license