Skip to content

chore(ci): use SHA as reference for integration test workflow instead of branch.#29787

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
AdnaneKhan:patch-1
Apr 10, 2024
Merged

chore(ci): use SHA as reference for integration test workflow instead of branch.#29787
mergify[bot] merged 1 commit intoaws:mainfrom
AdnaneKhan:patch-1

Conversation

@AdnaneKhan
Copy link
Copy Markdown
Contributor

Reason for this change

It is better to use an immutable commit reference for workflows that require approval, since the branch's head commit can change between the time of approval and workflow run execution.

Description of changes

Updated the ref parameter to use the SHA from the pull_request event instead of the ref.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 10, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@AdnaneKhan AdnaneKhan changed the title fix(ci): Use SHA as reference for integration test workflow instead of branch. fix(ci): use SHA as reference for integration test workflow instead of branch. Apr 10, 2024
@AdnaneKhan AdnaneKhan changed the title fix(ci): use SHA as reference for integration test workflow instead of branch. chore(ci): use SHA as reference for integration test workflow instead of branch. Apr 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 10, 2024 19:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8a73a00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f7d4f41 into aws:main Apr 10, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 10, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants