refactor(codepipeline): change the API of cross-region replication Buckets#2977
Merged
skinny85 merged 1 commit intoaws:masterfrom Jun 21, 2019
Merged
Conversation
2 tasks
eladb
approved these changes
Jun 21, 2019
…ckets. Users are now supposed to pass instances of IBucket instead of just Bucket names. Changed the name and type of the Pipeline.crossRegionScaffold property. BREAKING CHANGE: the Pipeline construction property crossRegionReplicationBuckets now takes values of type IBucket instead of string. * The property Pipeline.crossRegionScaffoldStacks has been renamed to crossRegionSupport, and its type changed from CrossRegionScaffoldStack to CrossRegionSupport.
65ba73b to
7503639
Compare
Contributor
Author
|
Changed the name of the support Stack to |
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Sep 24, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users are now supposed to pass instances of IBucket instead of just Bucket names.
Changed the name and type of the Pipeline.crossRegionScaffold property.
BREAKING CHANGE: the Pipeline construction property crossRegionReplicationBuckets now takes values of type IBucket instead of string.
and its type changed from CrossRegionScaffoldStack to CrossRegionSupport.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.