Skip to content

chore(ec2): NatInstanceProviderV2 security group example#29769

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
nmussy:chore-nat-gateway-security-group
Apr 11, 2024
Merged

chore(ec2): NatInstanceProviderV2 security group example#29769
mergify[bot] merged 3 commits intoaws:mainfrom
nmussy:chore-nat-gateway-security-group

Conversation

@nmussy
Copy link
Copy Markdown
Contributor

@nmussy nmussy commented Apr 9, 2024

Issue # (if applicable)

Closes #27527

Reason for this change

The current NatInstanceProviderV2.securityGroup property is unusable, given the dependency loop between the construct props (NatInstanceProviderV2 > VPC > SecurityGroup > NatInstanceProviderV2).
When creating the integration for #29729, adding a getter for the instances generated by the provider to update the instance role was required to test the userData overload. This solution also allows to bypass the circular dependency describe above, given that both the VPC and the instances are generated once the VPC is created with the natGatewayProvider.

Description of changes

  • Deprecate NatInstanceProviderV2.securityGroup
    • Add @example tag to demo NatInstanceProviderV2.gatewayInstances
  • Update README to demo setting the security group
  • Update integ to test the demo

Description of how you validated changes

Updated integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 9, 2024 07:29
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Apr 9, 2024
@nmussy
Copy link
Copy Markdown
Contributor Author

nmussy commented Apr 9, 2024

@arachnilith Can you confirm that this covers the feature request you raised in #27527?

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 9, 2024
GavinZZ
GavinZZ previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the change.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review April 11, 2024 00:17

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 11, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 88c52e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ea98d13 into aws:main Apr 11, 2024
@nmussy nmussy deleted the chore-nat-gateway-security-group branch April 11, 2024 08:23
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-cdk/aws-ec2: Better Support for NAT Gateway Construction in L2 Vpc

3 participants

@nmussy @aws-cdk-automation @GavinZZ