feat(elasticloadbalancingv2): add removeSuffix param for ExternalApplicationListener.addAction() by ahammond · Pull Request #29746 · aws/aws-cdk

ahammond · 2024-04-05T20:59:09Z

Issue # (if applicable)

Closes #29496

Reason for this change

See #29513 (props based solution instead of feature-flag)

Description of changes

Adds a removeSuffix property to addAction method to address problems due to logicalId inconsistency.

Description of how you validated changes

UTs. Per IT document, integration tests are not necessary.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

ahammond · 2024-04-05T21:02:07Z

Exemption Request: this change doesn't touch any of the aspects which would require IT.

packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-listener.ts

vinayak-kukreja

I have a general question and please let me know if I am missing historical context here :)

Is addAction covering all that is done by addTargetGroups and adds more to it? If yes, do we want two functions doing somewhat similar things to exist? I believe it adds more confusion
If prior scenario is true, where addAction just supercedes addTargetGroups, then why can we just not deprecate addTargetGroups and remove Rule suffix from addAction and add all of this behind a feature flag?

vinayak-kukreja · 2024-04-17T16:34:58Z

I have a general question and please let me know if I am missing historical context here :)

* Is `addAction` covering all that is done by `addTargetGroups` and adds more to it? If yes, do we want two functions doing somewhat similar things to exist? I believe it adds more confusion

* If prior scenario is true, where `addAction` just supercedes `addTargetGroups`, then why can we just not deprecate `addTargetGroups` and remove `Rule` suffix from `addAction` and add all of this behind a feature flag?

Ok, so I see addAction provides more control but addTargetGroups provides an abstracted version of it's functionality with some defaults.
In that case, IMO this configuration via props is becoming a bit confusing. I understand that we are trying to minimize using feature flags but adding it here probably will make a cleaner contract for the user. Thoughts?

ahammond · 2024-04-17T20:17:02Z

I removed addTargetGroup() related changes from this PR. I really need the addAction() stuff resolved so we can move forward.

ahammond · 2024-04-17T20:22:48Z

Ok, so I see addAction provides more control but addTargetGroups provides an abstracted version of it's functionality with some defaults. In that case, IMO this configuration via props is becoming a bit confusing. I understand that we are trying to minimize using feature flags but adding it here probably will make a cleaner contract for the user. Thoughts?

I've pulled out the stuff addressing the addTargetGroups from this PR to only address the problem which is blocking us. I think that the Right Way to address this going forward for the addTargetGroups() is a feature flag along the lines of what I wrote with #29513

But let's go one step at a time.

TheRealAmazonKendra · 2024-04-17T22:20:15Z

@Mergifyio update

mergify · 2024-04-17T22:20:30Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

TheRealAmazonKendra · 2024-04-17T22:20:52Z

Oh mergify...

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2024-04-17T22:50:29Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-04-17T23:18:21Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 573af28
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-04-17T23:18:44Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-25T21:17:41Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Apr 5, 2024

aws-cdk-automation requested a review from a team April 5, 2024 20:59

mergify bot mentioned this pull request Apr 5, 2024

feat(elasticloadbalancingv2): removeRuleSuffixFromLogicalId support #29745

Closed

aws-cdk-automation previously requested changes Apr 5, 2024

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 5, 2024

TheRealAmazonKendra requested changes Apr 5, 2024

View reviewed changes

packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Apr 8, 2024

Weekly PR metrics report #29758

Closed

ahammond force-pushed the logicalId-via-props branch 2 times, most recently from d2703ac to 8fc296a Compare April 12, 2024 23:15

TheRealAmazonKendra requested changes Apr 17, 2024

View reviewed changes

vinayak-kukreja reviewed Apr 17, 2024

View reviewed changes

ahammond changed the title ~~feat(elasticloadbalancingv2): removeRuleSuffixFromLogicalId support~~ feat(elasticloadbalancingv2): add removeSuffix param for ExternalApplicationListener.addAction() Apr 17, 2024

ahammond added 4 commits April 17, 2024 13:23

feat(elasticloadbalancingv2): removeRuleSuffixFromLogicalId support

201bc47

lint

a29dd22

README update

923a1e8

retain legacy behavior for addTargetGroups

67d83c5

ahammond force-pushed the logicalId-via-props branch from 9f5e2e4 to bec3057 Compare April 17, 2024 20:23

address comments

2186314

ahammond force-pushed the logicalId-via-props branch from bec3057 to 2186314 Compare April 17, 2024 20:24

Merge branch 'main' into logicalId-via-props

3555e43

TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 17, 2024

TheRealAmazonKendra approved these changes Apr 17, 2024

View reviewed changes

Merge branch 'main' into logicalId-via-props

573af28

mergify bot merged commit f4af330 into aws:main Apr 17, 2024

ahammond deleted the logicalId-via-props branch April 17, 2024 23:41

github-actions bot mentioned this pull request May 1, 2024

Monthly PR metrics report #30026

Closed

This was referenced May 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#98

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#99

Open

NOUIY mentioned this pull request May 30, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#101

Open

NOUIY mentioned this pull request Jun 7, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#102

Open

niravparikh05 mentioned this pull request Jun 13, 2024

[Snyk] Upgrade aws-cdk from 2.65.0 to 2.142.1 paralus/eks-blueprints-addon#3

Open

NOUIY mentioned this pull request Jun 14, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#103

Open

snyk-io bot mentioned this pull request Jun 20, 2024

[Snyk] Upgrade aws-cdk-lib from 2.138.0 to 2.143.1 Opetushallitus/heratepalvelu#280

Closed

This was referenced Jun 20, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#104

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#105

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Conversation

ahammond commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

ahammond commented Apr 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinayak-kukreja left a comment

Choose a reason for hiding this comment

Uh oh!

vinayak-kukreja commented Apr 17, 2024

Uh oh!

ahammond commented Apr 17, 2024

Uh oh!

ahammond commented Apr 17, 2024

Uh oh!

TheRealAmazonKendra commented Apr 17, 2024

Uh oh!

mergify bot commented Apr 17, 2024

❌ Mergify doesn't have permission to update

Uh oh!

TheRealAmazonKendra commented Apr 17, 2024

Uh oh!

mergify bot commented Apr 17, 2024

Uh oh!

aws-cdk-automation commented Apr 17, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 17, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ahammond commented Apr 5, 2024 •

edited

Loading