Skip to content

revert: "fix(elasticloadbalancerV2): logicalId supports switch from addTargetGroups (under feature flag)"#29716

Merged
mergify[bot] merged 1 commit intomainfrom
revert-29513-logicalId-consistency
Apr 4, 2024
Merged

revert: "fix(elasticloadbalancerV2): logicalId supports switch from addTargetGroups (under feature flag)"#29716
mergify[bot] merged 1 commit intomainfrom
revert-29513-logicalId-consistency

Conversation

@scanlonp
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp commented Apr 4, 2024

Reverts #29513

We will want to use a property to achieve the desired behavior instead of a feature flag since we are not changing the default behavior.

@github-actions github-actions bot added the p2 label Apr 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 4, 2024 00:21
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 4, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c6e5375
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b82320b into main Apr 4, 2024
@mergify mergify bot deleted the revert-29513-logicalId-consistency branch April 4, 2024 00:49
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants