feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask#29638
feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask#29638mergify[bot] merged 4 commits intoaws:mainfrom matthiasgubler:29637-enableexecutecommand-ecs-sfn
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aaythapa
left a comment
There was a problem hiding this comment.
Thank you for making this change! Most of the diff seem to come from format, not sure if that was intentional. If you could remove those as the format doesn't match the rest of the repo.
Also would prefer a bit more documentation or links to some (maybe in the README).
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-ecs-task-base.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue #29637
Closes #29637
Reason for this change
Allow setting the enableExecuteCommand for ECSRunTask in sfn
Description of changes
Add the enableExecuteCommand property to the EcsRunTaskProps, to start the task from step functions with execution command enabled.
Description of how you validated changes
Unit-test added. Existing ones passed.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license