Skip to content

docs(custom-resources): fix dead links in custom-resources package documentation#29599

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
Booligoosh:patch-1
Mar 27, 2024
Merged

docs(custom-resources): fix dead links in custom-resources package documentation#29599
mergify[bot] merged 3 commits intoaws:mainfrom
Booligoosh:patch-1

Conversation

@Booligoosh
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

The links to the example files at https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html#provider-framework-examples are no longer valid since the repository underwent restructuring.

Description of changes

Replaces the URLs to the S3File and S3Assert example files with valid GitHub links

Description of how you validated changes

Visited the updated links

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 25, 2024 03:00
@github-actions github-actions bot added the p2 label Mar 25, 2024
@Booligoosh Booligoosh changed the title Fix dead links in custom-resources package documentation docs(custom-resources): fix dead links in custom-resources package documentation Mar 25, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 25, 2024
scanlonp
scanlonp previously approved these changes Mar 27, 2024
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Thank you!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 27, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed scanlonp’s stale review March 27, 2024 07:23

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 197d01f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 217f8be into aws:main Mar 27, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced Apr 1, 2024
@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants