Skip to content

chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated#29580

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
nikovirtala:fix/false-deprecation
Apr 17, 2024
Merged

chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated#29580
mergify[bot] merged 6 commits intoaws:mainfrom
nikovirtala:fix/false-deprecation

Conversation

@nikovirtala
Copy link
Copy Markdown
Contributor

@nikovirtala nikovirtala commented Mar 22, 2024 •
edited
Loading

Issue # (if applicable)

Closes #.

Reason for this change

AWS CodeBuild Docker images AMAZON_LINUX_2_ARM_3 aka AMAZON_LINUX_2_STANDARD_3_0 aka aws/codebuild/amazonlinux2-aarch64-standard:3.0 and AMAZON_LINUX_2_ARM_2 aka AMAZON_LINUX_2_STANDARD_2_0 aka aws/codebuild/amazonlinux2-aarch64-standard:2.0are not deprecated but the currently actively maintained ones according to https://github.com/aws/aws-codebuild-docker-images and https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

Description of changes

I removed the JSDoc Deprecated flag for the currently active images and added their image names as a comment so that one can find the images also using those references.

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Mar 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 22, 2024 17:11
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@nikovirtala
Copy link
Copy Markdown
Contributor Author

nikovirtala commented Mar 22, 2024

Exemption Request: this change doesn't change any feature or functionality — thus, no test should and does not change

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 22, 2024
lpizzinidev
lpizzinidev suggested changes Mar 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Left a comment for updating v2 documentation as well.
I think you can mark the PR as a chore (CI won't require tests).
Also, can you please update the title to not be truncated?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 23, 2024
@nikovirtala nikovirtala changed the title fix(codebuild): aws/codebuild/amazonlinux2-aarch64-standard:3.0 is no… chore(codebuild): aarch64 standard 2.0 and 3.0 are not deprecated Mar 25, 2024
@nikovirtala nikovirtala changed the title chore(codebuild): aarch64 standard 2.0 and 3.0 are not deprecated chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated Mar 25, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 25, 2024 06:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@nikovirtala
Copy link
Copy Markdown
Contributor Author

nikovirtala commented Mar 25, 2024

Thanks 👍 Left a comment for updating v2 documentation as well. I think you can mark the PR as a chore (CI won't require tests). Also, can you please update the title to not be truncated?

I removed the @deprecated flag also for v2 image and update the pr title and description to cover that change too.

@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Closed
@nmussy
Copy link
Copy Markdown
Contributor

nmussy commented Mar 25, 2024

Hey, guess I didn't open a PR for this (I was sure I did), but I already have a runner ready to update all of the CodeBuild images (WindowsBuildImage, LinuxBuildImage, LinuxArmBuildImage, LinuxLambdaBuildImage, and LinuxArmLambdaBuildImage). I'll try to take care of this soon.

Regardless, you can confirm that these images are still available by using the codebuild:ListCuratedEnvironmentImages API command:

$ aws codebuild list-curated-environment-images | jq '.platforms[] | select(.platform == "AMAZON_LINUX_2") | .languages[] | select(.language == "STANDARD") | .images[] | select(.name == "aws/codebuild/amazonlinux2-aarch64-standard:3.0")'

{
  "name": "aws/codebuild/amazonlinux2-aarch64-standard:3.0",
  "description": "AWS CodeBuild - Docker image based on Amazon Linux 2023 (aarch64) with multiple language support",
  "versions": [
    "aws/codebuild/amazonlinux2-aarch64-standard:3.0-23.04.25",
    "aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.01.29",
    "aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.03.06",
    "aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.03.21"
  ]
}
$ aws codebuild list-curated-environment-images | jq '.platforms[] | select(.platform == "AMAZON_LINUX_2") | .languages[] | select(.language == "STANDARD") | .images[] | select(.name == "aws/codebuild/amazonlinux2-aarch64-standard:2.0")'
{
  "name": "aws/codebuild/amazonlinux2-aarch64-standard:2.0",
  "description": "AWS CodeBuild - Docker image based on Amazon Linux 2 (aarch64) with multiple language support",
  "versions": [
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-20.06.15",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-20.08.13",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.01.12",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.03.02",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.08.20",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.10.15",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.01.29",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.03.06",
    "aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.03.21"
  ]
}

@nmussy nmussy mentioned this pull request Mar 26, 2024
Closed
1 task
@nmussy
Copy link
Copy Markdown
Contributor

nmussy commented Mar 26, 2024

I opened another PR to fix this issue, among other things: #29616
Sorry about that, I had everything ready but forgot to actually make the changes 😞

@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Apr 17, 2024 •
edited
Loading

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

update

☑️ Nothing to do

Details
  • queue-position=-1 [📌 update requirement]
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 17, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eecb081
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1f8bc90 into aws:main Apr 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@lpizzinidev lpizzinidev lpizzinidev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikovirtala @nmussy @TheRealAmazonKendra @aws-cdk-automation @lpizzinidev